[lldb][NFC] Move discovery of local variables earlier in expr eval #5790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the discovery of local variables form SwiftExpressionParser to SwiftUserExpression. This has two main benefits: - In case we're binding generic parameters, we can fail earlier if we can't bind some variable. - Prepares the path to implement expression evaluation with an unlimited amount of generic parameters.
|
@swift-ci test |
| lldb::ExpressionVariableSP &persistent_variable_sp) | ||
| : m_persistent_variable_sp(persistent_variable_sp) {} | ||
|
|
||
| static constexpr unsigned Type() { return 'Pers'; } |
There was a problem hiding this comment.
Looks like the metadata type controls how materialization works. It's only used in MaterializeVariable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the discovery of local variables form SwiftExpressionParser to SwiftUserExpression. This has two main benefits: