Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also disable flang test on [Fedora] Linux #72

Conversation

davezarzycki
Copy link

@davezarzycki davezarzycki commented Oct 31, 2019

See #63 and #69.

@davezarzycki
Copy link
Author

@swift-ci please test platform

@davezarzycki
Copy link
Author

@shahmishal – Looks like @swift-ci is ignoring me because I don't have write access to the repo. I also can't add you as a reviewer for some reason. Weird.

@davezarzycki
Copy link
Author

@swift-ci please test platform

@davezarzycki
Copy link
Author

@shahmishal – Thanks for the commit access. For future reference: where are the docs for the stable/$DATE branches and in particular, when/where should pull requests target stable/$DATE versus just swift/master? Would it have been okay if I just requested that this be merged into swift/master? Thanks!

Copy link

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyp
Copy link

hyp commented Oct 31, 2019

@davezarzycki swift/master is reserved for LLDB changes only. @JDevlieghere is working on automerger graph that we can add to the README to show the merge graph to explain this better.

@davezarzycki
Copy link
Author

Okay. Is apple/stable/20190619 the right place for this fix? And yes, it would be nice if this were documented.

@davezarzycki
Copy link
Author

Ping. Is apple/stable/20190619 the right place for this fix?

@shahmishal
Copy link
Member

I recommend this change should be made on apple/llvm-project:apple/master, if it can't be made on llvm/llvm-project:master. However, it should still be on apple/stable/20190619 branch.

  • apple/stable/20190619 branch was created from apple/master on June 19 2019
  • apple/stable/20190619 gets automerged into swift/master branch.

@davezarzycki
Copy link
Author

@shahmishal – This is fallout from cherry-picking changes so LLVM proper doesn't need this fix. If I understand you correctly, I need two pull requests? One for apple/master and one for apple/stable/20190619?

@davezarzycki
Copy link
Author

@shahmishal – Ping. If I understand you correctly, I need two pull requests? One for apple/master and one for apple/stable/20190619?

@shahmishal
Copy link
Member

@davezarzycki Yes, that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants