-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also disable flang test on [Fedora] Linux #72
Also disable flang test on [Fedora] Linux #72
Conversation
@swift-ci please test platform |
@shahmishal – Looks like @swift-ci is ignoring me because I don't have write access to the repo. I also can't add you as a reviewer for some reason. Weird. |
@swift-ci please test platform |
@shahmishal – Thanks for the commit access. For future reference: where are the docs for the stable/$DATE branches and in particular, when/where should pull requests target stable/$DATE versus just swift/master? Would it have been okay if I just requested that this be merged into swift/master? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davezarzycki swift/master is reserved for LLDB changes only. @JDevlieghere is working on automerger graph that we can add to the README to show the merge graph to explain this better. |
Okay. Is |
Ping. Is apple/stable/20190619 the right place for this fix? |
I recommend this change should be made on
|
@shahmishal – This is fallout from cherry-picking changes so LLVM proper doesn't need this fix. If I understand you correctly, I need two pull requests? One for |
@shahmishal – Ping. If I understand you correctly, I need two pull requests? One for apple/master and one for apple/stable/20190619? |
@davezarzycki Yes, that is correct. |
See #63 and #69.