Skip to content

[upstreaming] Revert removal of comment in SBAddress.h #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Teemperor
Copy link

That's a difference to upstream

@Teemperor Teemperor requested a review from dcci October 31, 2019 13:04
@Teemperor
Copy link
Author

@swift-ci test

Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the same comment applies [we need this change both in swift/master and swift/master-next

@Teemperor Teemperor force-pushed the RevertRemovedCommentSBAddress branch from b08ceaa to 1a85a17 Compare November 1, 2019 08:40
@Teemperor
Copy link
Author

@swift-ci test

@Teemperor Teemperor changed the title Revert removal of comment in SBAddress.h [upstreaming] Revert removal of comment in SBAddress.h Nov 1, 2019
@Teemperor Teemperor merged commit 5d68050 into swiftlang:swift/master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants