[clang][lex] Fix non-portability diagnostics with absolute path (#74782) #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#74782) The existing code incorrectly assumes that `Path` can be empty. It can't, it always contains at least `<` or `"`. On Unix, this patch fixes an incorrect diagnostics that instead of `"/Users/blah"` suggested `"Userss/blah"`. In assert builds, this would outright crash. This patch also fixes a bug on Windows that would prevent the diagnostic being triggered due to separator mismatch. rdar://91172342 (cherry picked from commit f0691bc)
|
@swift-ci please test |
jansvoboda11
deleted the
jan_svoboda/stable-20230725-case-mismatch-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code incorrectly assumes that
Pathcan be empty. It can't, it always contains at least<or". On Unix, this patch fixes an incorrect diagnostics that instead of"/Users/blah"suggested"Userss/blah". In assert builds, this would outright crash.This patch also fixes a bug on Windows that would prevent the diagnostic being triggered due to separator mismatch.
rdar://91172342
(cherry picked from commit f0691bc)