[WIP] Add support for capturing all possible versioned APINotes without applying them #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
SwiftAPINotesVersionedProto
branch
from
8168178
to
affd807
Compare
|
@swift-ci test |
artemcm
force-pushed
the
SwiftAPINotesVersionedProto
branch
from
affd807
to
953f903
Compare
…ut applying them Leaving it up to the client to select the appropriate version to apply
artemcm
force-pushed
the
SwiftAPINotesVersionedProto
branch
from
953f903
to
7ee2b42
Compare
|
@swift-ci test |
|
@egorzhdan I'm working on adding tests for this, but would be curious to get your thoughts on the overall approach. |
artemcm
requested review from
MaxDesiatov and
egorzhdan
and removed request for
MaxDesiatov
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving it up to the client to select the appropriate version to apply.