Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Use Windows-specific LLDB test args on Windows #9103

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[cmake] Use Windows-specific LLDB test args on Windows #9103

wants to merge 1 commit into from

Conversation

kendalharland
Copy link

@kendalharland kendalharland commented Aug 13, 2024 •
edited
Loading

This PR avoids hardcoding macosx and darwin into DYLD_LIBRARY_PATH, which becomes part of LLDB_TEST_COMMON_ARGS and breaks the LLDB test build on Windows.

Related to #9141

@kendalharland kendalharland mentioned this pull request Aug 17, 2024
Open
@kendalharland
Copy link
Author

Hi @JDevlieghere! Apologies as I've been out on vacation. Would you please take a look at this change?

@hjyamauchi
Copy link

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Oct 1, 2024

@swift-ci please test Windows platform

@weliveindetail
Copy link

Windows platform test failed:

ninja: error: unknown target 'clang-pseudo-gen'
Error: Error: cmake.exe exited with code 1.
Invocation:
  cmake.exe --build T:\0 --target clang-pseudo-gen

@compnerd
Copy link
Member

compnerd commented Oct 2, 2024

@swift-ci please test Windows platform

@weliveindetail weliveindetail mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjyamauchi hjyamauchi hjyamauchi approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kendalharland @hjyamauchi @compnerd @weliveindetail