[lldb] Update Measurement data formatter #9127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View the diff with whitespace ignored for a distilled look at the changes (basically a new else branch added) https://github.com/swiftlang/llvm-project/pull/9127/files?w=1 |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
| @@ -13,8 +13,8 @@ import Foundation | |||
|
|
|||
| func main() { | |||
| var measurement = Measurement(value: 1.25, unit: Unit(symbol: "m")) | |||
| //% self.runCmd("settings set symbols.swift-enable-ast-context false") | |||
There was a problem hiding this comment.
Can you add a comment explaining why this is here?
Ideally, we would convert this into a non-inline test and run the test with and without the setting, otherwise we're losing the typeref <-> SwiftAST validation.
kastiglione
force-pushed
the
dl/lldb-Update-Measurement-data-formatter
branch
from
b162992
to
5e21b98
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
approved these changes
Oct 3, 2024
...test/API/lang/swift/foundation_value_types/measurement/TestSwiftFoundationTypeMeasurement.py
Outdated
Show resolved
Hide resolved
kastiglione
added a commit
that referenced
this pull request
Oct 29, 2024
rdar://121940851 (cherry picked from commit c45216d)
kastiglione
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://121940851