[lldb] Add Swift syntax highlighting using SwiftSyntax #9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
requested review from
kastiglione,
JDevlieghere,
bulbazord and
adrian-prantl
|
@swift-ci test |
Use SwiftSyntax to parse source code that will be displayed in command line LLDB and syntax highlight it. This adds a new CMake project under Plugins/Language/Swift/SwiftHighlighter, which has a dependency on the SwiftSyntax shared library which is already used by the compiler.
|
@swift-ci test |
augusto2112
force-pushed
the
swift-highlight
branch
from
b588c37
to
915077f
Compare
|
@swift-ci test |
| @@ -0,0 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
Should/Could this be project-wide and at a much higher directory level?
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "version": 1, | |||
| "lineLength": 120, | |||
There was a problem hiding this comment.
Why does Swift get a longer line length?
|
|
||
| # Verify that we have a new enough compiler | ||
| if("${CMAKE_Swift_COMPILER_VERSION}" VERSION_LESS 5.9) | ||
| message(FATAL_ERROR "Bidirectional C++ Interop requires Swift 5.9 or greater. Have ${CMAKE_Swift_COMPILER_VERSION}") |
|
|
||
| enum AnsiColor { | ||
| enum Bright { | ||
| static let red = String(ansi.FormatAnsiTerminalCodes(std.string("${ansi.fg.bright.red}"), true)) |
There was a problem hiding this comment.
Could String(ansi.FormatAnsiTerminalCodes(std.string(someString), true)) be a helper function?
| case function | ||
| case functionLabel | ||
|
|
||
| func getColor() -> String { |
| @@ -0,0 +1,66 @@ | |||
| # Generate the bridging header from Swift to C++ | |||
There was a problem hiding this comment.
Isn't the word "bridging header" only used for the opposite direction?
| @@ -0,0 +1,182 @@ | |||
| //===----------------------------------------------------------------------===// | |||
| // | ||
| // This source file is part of the Swift open source project | ||
| // | ||
| // Copyright (c) 2023 Apple Inc. and the Swift project authors. |
| #ifndef SWIFTHIGHLIGHTERSUPPORT_H | ||
| #define SWIFTHIGHLIGHTERSUPPORT_H | ||
|
|
||
| #define ANSI_FG_COLOR_BLACK 30 |
There was a problem hiding this comment.
These probably shouldn't be #defines anyway. Could you factor these enums out into a new header upstream that you can import into Swift?
| const char *value; | ||
| } g_color_tokens[] = { | ||
| #define _TO_STR2(_val) #_val | ||
| #define _TO_STR(_val) _TO_STR2(_val) |
There was a problem hiding this comment.
I don't think this needs to be in the header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SwiftSyntax to parse source code that will be displayed in command line LLDB and syntax highlight it. This adds a new CMake project under Plugins/Language/Swift/SwiftHighlighter, which has a dependency on the SwiftSyntax shared library which is already used by the compiler.