[c-index-test] Fix JSON string quoting #9864
Open
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez
reviewed
Jan 22, 2025
ellishg
reviewed
Jan 22, 2025
Wilfred
force-pushed
the
c-index-test-valid-json
branch
from
a94f892 to
ce2d1fe
Compare
|
@swift-ci please test llvm |
|
@swift-ci please smoke test |
Previously, c-index-test assumed that all it could write strings to the JSON output directly. This breaks if any strings contain double-quotes or backslashes, which can occur for C++ string literals. Ensure that strings are properly quoted for JSON, and add a test for string literals.
Wilfred
force-pushed
the
c-index-test-valid-json
branch
from
ce2d1fe to
a0f7924
Compare
|
@swift-ci please test llvm |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, c-index-test assumed that all it could write strings to the JSON output directly. This breaks if any strings contain double-quotes or backslashes, which can occur for C++ string literals.
Ensure that strings are properly quoted for JSON, and add a test for string literals.