Skip to content

Don’t crash when opening a file with an empty path #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Don’t crash when opening a file with an empty path #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/LanguageServerProtocol/SupportTypes/DocumentURI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ public struct DocumentURI: Codable, Hashable, Sendable {
/// fallback mode that drops semantic functionality.
public var pseudoPath: String {
if storage.isFileURL {
return storage.withUnsafeFileSystemRepresentation {
String(cString: $0!)
return storage.withUnsafeFileSystemRepresentation { filePath in
if let filePath {
String(cString: filePath)
} else {
""
}
}
} else {
return storage.absoluteString
Expand Down
5 changes: 5 additions & 0 deletions Tests/SourceKitLSPTests/LifecycleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,9 @@ final class LifecycleTests: XCTestCase {
)
)
}

func testOpenFileWithoutPath() async throws {
let testClient = try await TestSourceKitLSPClient()
testClient.openDocument("", uri: DocumentURI(try XCTUnwrap(URL(string: "file://"))), language: .swift)
}
}