Add another import of new Android overlay and remove non-existent file exclusion from package manifest #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e exclusion from package manifest
ahoppen
approved these changes
Dec 3, 2024
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks for fixing the manifest warning as well.
Member
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what's going on with the symbol lookup in the compiler, as I built the Oct. 8 trunk source snapshot fine without this import and then started seeing this file erroring this month on my Android CI, finagolfin/swift-android-sdk@15b148d1c, and now natively on Android with the Nov. 20 trunk snapshot, without any seemingly relevant changes in this file.
As for the manifest, looks like Alex copy-pasted that line from the non-test target, but tests don't have a CMake config, causing this warning on the CI which I also saw locally: