Cached transformed results in Cache
#1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
hamishknight
reviewed
Dec 6, 2024
Sources/SwiftExtensions/Cache.swift
Outdated
Comment on lines
43
to
46
| let transformed = Task { try await transform(value.value) } | ||
| // Cache the transformed result. | ||
| storage[key] = transformed | ||
| return try await transformed.value |
Contributor
There was a problem hiding this comment.
Won't this re-apply the transform for every subsequent access?
Member
Author
There was a problem hiding this comment.
Indeed, this was wrong on so many different levels. Thanks for catching it in the review, this would have been a pain to debug.
ahoppen
force-pushed
the
cache-transformed
branch
from
56155f8 to
2e756ac
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Dec 6, 2024
The transform to get the transformed result might be expensive, so we should cache its result.
ahoppen
force-pushed
the
cache-transformed
branch
from
2e756ac to
1c1a1cf
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transform to get the transformed result might be expensive, so we should cache its result.