Skip to content

Treat $/setTrace as a freestanding message #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahoppen merged 1 commit into from
Dec 6, 2024
Merged

Treat $/setTrace as a freestanding message #1871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/SourceKitLSP/MessageHandlingDependencyTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ package enum MessageHandlingDependencyTracker: QueueBasedMessageHandlerDependenc
case let notification as ReopenTextDocumentNotification:
self = .documentUpdate(notification.textDocument.uri)
case is SetTraceNotification:
self = .globalConfigurationChange
// `$/setTrace` changes a global configuration setting but it doesn't affect the result of any other request. To
// avoid blocking other requests on a `$/setTrace` notification the client might send during launch, we treat it
// as a freestanding message.
// Also, we don't do anything with this notification at the moment, so it doesn't matter.
self = .freestanding
case is ShowMessageNotification:
self = .freestanding
case let notification as WillSaveTextDocumentNotification:
Expand Down