[6.0] Normalize Windows drive letter to be uppercase #1881
Closed
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Dec 11, 2024
ahoppen
commented
- Explanation: VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Because of this casing inconsistency, we don’t show diagnostics on Windows. Normalize the drive letter spelling to be uppercase to fix the issue.
- Scope: LSP messages on Windows that use a lowercase drive letter
- Risk: Only affects Windows but modifies that at a very central position. But uppercasing the drive letter for internal processing should be safe.
- Testing: Verified that we show diagnostics with this fix
- Issue: SourceKit-LSP not publishing diagnostics on Windows #1855 / rdar://141001203
- Reviewer: @bnbarham on Normalize Windows drive letter to be uppercase #1880
|
@swift-ci Please test |
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase. Fixes swiftlang#1855 rdar://141001203
ahoppen
force-pushed
the
6.0/normalize-drive-letter
branch
from
53df6b2 to
9fa5200
Compare
|
@swift-ci Please test |
|
@swift-ci Please build toolchain Windows |
|
@swift-ci Please build toolchain |
Why unmerged ? Has this problem been fixed ? |
|
This issue has been fixed in Swift 6.1 toolchains for quite a while now and I think it’s unlikely that we’ll release an updated 6.0 toolchain for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.