Fix yaml lint error and remove offensive terms from the codebase #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
bnbarham
reviewed
Mar 7, 2025
Sources/LanguageServerProtocol/SupportTypes/VersionedTextDocumentIdentifier.swift
Outdated
Show resolved
Hide resolved
| extension Process { | ||
| /// Wait for the process to exit. If the task gets cancelled, during this time, send a `SIGINT` to the process. | ||
| /// Should the process not terminate on SIGINT after 2 seconds, it is killed using `SIGKILL`. | ||
| /// Should the process not terminate on SIGINT after 2 seconds, it is terminated using `SIGKILL`. # ignore-unacceptable-language |
Contributor
There was a problem hiding this comment.
No way to avoid this one but... The # ignore-unacceptable-language does show up in the help 🤔
Contributor
There was a problem hiding this comment.
Ah, I believe the issue is only kill (the function) and not SIGKILL. Which makes sense, otherwise surely there'd be a fair few false positives with kill anywhere in a word.
ahoppen
force-pushed
the
soundness-checks
branch
from
e2a610c to
d77651c
Compare
ahoppen
force-pushed
the
soundness-checks
branch
from
d77651c to
8aa8fa0
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
2 similar comments
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test macOS |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.