Relax the assertion in testHighPriorityTasksGetExecutedBeforeLowPriorityTasks
#2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rityTasks` I just received the following recordings during local test execution: ``` Set([high(1), high(0)]) Set([high(1), high(0), high(2)]) Set([high(2), high(3), high(1), high(0)]) Set([high(2), high(3), high(1)]) Set([high(2), high(3)]) Set([high(2), high(3), high(4)]) Set([high(2), high(3), high(4), high(5)]) Set([high(3), high(4), high(5)]) Set([high(4), high(5)]) Set([high(4), high(5), high(6)]) Set([high(7), high(4), high(5), high(6)]) Set([high(7), high(5), high(6)]) Set([high(7), high(5)]) Set([high(5)]) Set([]) Set([low(0)]) Set([low(0), high(8)]) Set([low(0), high(8), low(1)]) Set([low(0), high(8), low(1), high(9)]) Set([low(0), high(8), low(1)]) Set([low(0), low(1)]) Set([low(1)]) Set([]) ... ``` These recordings didn't satisfy the old assertion because a low-priority task started executing before the last high-priority task. But really what happened is that `low(0)`, `high(8)`, `low(1)`, and `high(9)` were all scheduled simultaneously and `low(0)` just happened to start executing a tiny bit before `high(8)`. To account for these races, relax the assertion to check that all high-priority tasks start executing before the first low-priority task finishes executing.
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just received the following recordings during local test execution:
These recordings didn't satisfy the old assertion because a low-priority task started executing before the last high-priority task. But really what happened is that
low(0),high(8),low(1), andhigh(9)were all scheduled simultaneously andlow(0)just happened to start executing a tiny bit beforehigh(8). To account for these races, relax the assertion to check that all high-priority tasks start executing before the first low-priority task finishes executing.