Skip to content

Log contextual requests that affect sourcekitd’s global state #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Log contextual requests that affect sourcekitd’s global state #2094

merged 3 commits into from
May 14, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 27, 2025 •
edited
Loading

This way we can log them when a sourcekitd request crashes and we can thus replay these contextual requests when diagnosing the crash.

@ahoppen ahoppen force-pushed the contextual-sourcekitd-request branch 2 times, most recently from b8a09b5 to c0cd2ac Compare March 28, 2025 21:29
@ahoppen
Copy link
Member Author

ahoppen commented Mar 28, 2025

@swift-ci Please test

@ahoppen ahoppen marked this pull request as ready for review March 28, 2025 21:29
@ahoppen ahoppen force-pushed the contextual-sourcekitd-request branch from c0cd2ac to e481ad5 Compare May 8, 2025 11:51
@ahoppen
Copy link
Member Author

ahoppen commented May 8, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 8, 2025

@swift-ci Please test Windows

bnbarham
bnbarham reviewed May 9, 2025
View reviewed changes
ahoppen added 3 commits May 12, 2025 15:39
@ahoppen
Log contextual requests that affect sourcekitd’s global state
69ab356 
This way we can log them when a sourcekitd request crashes and we can thus replay these contextual requests when diagnosing the crash.
@ahoppen
Add contextual request support to sourcekit-lsp diagnose
da90f34 
Teach `sourcekit-lsp diagnose` how to extract contextual requests from the system log and use them to reduce sourcekitd crashes.
@ahoppen
Address review comments
d63419d
@ahoppen ahoppen force-pushed the contextual-sourcekitd-request branch from e481ad5 to d63419d Compare May 12, 2025 13:48
@ahoppen
Copy link
Member Author

ahoppen commented May 13, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 13, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 188e174 into swiftlang:main May 14, 2025
3 checks passed
@ahoppen ahoppen deleted the contextual-sourcekitd-request branch May 14, 2025 17:13
bnbarham added a commit to bnbarham/sourcekit-lsp that referenced this pull request May 19, 2025
@bnbarham
Revert "Merge pull request swiftlang#2094 from ahoppen/contextual-sou…
f6ff09b 
…rcekitd-request"

This reverts commit 188e174, reversing
changes made to be5ae8c. Should be a
fairly harmless change, but it's also quite large. Skipping for 6.2.
bnbarham added a commit to bnbarham/sourcekit-lsp that referenced this pull request May 20, 2025
@bnbarham
Revert "Merge pull request swiftlang#2094 from ahoppen/contextual-sou…
a0a8f1e 
…rcekitd-request"

This reverts commit 188e174, reversing
changes made to be5ae8c. Should be a
fairly harmless change, but it's also quite large. Skipping for 6.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham