Skip to content

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 25, 2025

Two improvements to the logic that determines if we need to reload the package on a file change:

  1. Only reload a package if the modified package manifest or Package.resolved is in the root of the package folder. This is relevant if we have a multi-root workspace, in which currently a single change to a package manifest or Package.resolved causes all packages to get reloaded.
  2. While I was at it, I noticed that we didn’t properly handle version-specific package manifests. Also trigger a package reload if a version-specific package manifest is modified, created or deleted.

Two improvements to the logic that determines if we need to reload the package on a file change:
1. Only reload a package if the modified package manifest or Package.resolved is in the root of the package folder. This is relevant if we have a multi-root workspace, in which currently a single change to a package manifest or Package.resolved causes all packages to get reloaded.
2. While I was at it, I noticed that we didn’t properly handle version-specific package manifests. Also trigger a package reload if a version-specific package manifest is modified, created or deleted.
@ahoppen
Copy link
Member Author

ahoppen commented Aug 25, 2025

@swift-ci Please test

@ahoppen ahoppen merged commit c31b62e into swiftlang:main Aug 25, 2025
3 checks passed
@ahoppen ahoppen deleted the only-reload-current-package branch September 3, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants