Show inlay hints of #if conditions at their corresponding #endif directives
#2323
+241
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Not against this at all, but it isn't really #2222 is it? It would really need an inactive regions request + support in vs code itself. FWIW clangd has textDocument/inactiveRegions (https://reviews.llvm.org/D143974), although it's not listed in their protocol extensions 🤷♂️
ahoppen
force-pushed
the
if-config-hints
branch
from
01acc0c to
9ca3197
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, also migrate the InlayType tests to use position markers.
Fixes #2222