Temporarily skip macro tests on Amazon Linux #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
ahoppen
reviewed
Nov 5, 2025
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Don’t like the double negative with SkipUnless.isNot but I don’t have a better solution.
bnbarham
force-pushed
the
skip-amazon-linux
branch
from
98c1ed1 to
1e833a8
Compare
These are failing on the 2023 bootstrap job, skip for now to allow getting a toolchain out.
bnbarham
force-pushed
the
skip-amazon-linux
branch
from
1e833a8 to
d046c7b
Compare
Contributor
Author
Yeah me neither, I don't care too much though - I'll fix this properly next week |
Contributor
Author
|
@swift-ci please test |
Member
|
@swift-ci Please test Windows |
ahoppen
approved these changes
Nov 5, 2025
Contributor
Author
|
Merging to unblock AL2023 (windows failure is unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are failing on the 2023 bootstrap job, skip for now to allow getting a toolchain out.