fixed padding between footer social icons #322
Conversation
There was a problem hiding this comment.
I left a small suggestion for style.
More broadly, although I think this change would indeed fix the issue for the book's footer, a decent amount of the style info comes from https://swift.org/assets/stylesheets/docc/footer.css, which we share with the DocC documentation. It lives over in the swiftlang/swift-org-website repository.
Maybe that's a better place to make a change to fix this, since it'd help the DocC docs too.
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
|
Hey @krilnon, thanks for the suggestion, will look into that way as well, and for the time being have made the requested change |
|
@amartini51 If you have thoughts one way or the other on accepting the quick fix here or waiting for a possible upstream fix, your input is welcome. |
|
Thanks for working on this fix! (I was out of the office for 2 weeks when this PR first came through. Thanks for your patience waiting for review.) I'd prefer to correct the CSS in the main Swift.org repo, and then match that correction here. I think that will also get you better review on the CSS, since there are more folks working on that repository with an expertise in CSS. I only know CSS at a general level, and have not kept up with all the latest changes. |
|
Moving this PR to "draft" while the changes are being proposed and reviewed for the main Swift.org website. After we merge the changes there, we'll make the corresponding changes here. |
Fix: #321