Reference for integer generic parameters [SE-0452] #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several places in the grammar allow an optional minus sign followed by an integer literal, which this simplifies. However, there is some argument for keeping the minus sign separate, because it isn't part of the literal. This is a "signed integer literal" in that it's an integer literal that can have a minus sign, not a literal of a signed integer.
colleenish
suggested changes
Oct 10, 2025
colleenish
left a comment
colleenish
left a comment
There was a problem hiding this comment.
First pass edits. A handful of fixes; let me know if you'd like to discuss anything.
Changes from <rdar://162313224>. Co-authored-by: Colleen Toporek <colleen_toporek@apple.com>
colleenish
approved these changes
Oct 13, 2025
colleenish
left a comment
colleenish
left a comment
There was a problem hiding this comment.
Looks good. No additional changes from me.
rolsen8
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: rdar://149983186