Rename specs to workaround windows whitespace-escaping issues #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
force-pushed
the
owenv/shell-escaping
branch
4 times, most recently
from
d58bfff to
e80c35b
Compare
owenv
force-pushed
the
owenv/shell-escaping
branch
from
e80c35b to
921cbbc
Compare
owenv
changed the title
|
@swift-ci test |
owenv
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
Renaming the specs here is annoying, but I could not find a way to do the escaping which worked both when cmake collapses the custom commands into a batch file and when it doesn't |
neonichu
approved these changes
May 12, 2025
|
Meh, good riddance to spaces in filenames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix an issue on Windows when the generator collapses the post-build commands for SWBApplePlatform into a batch script