Set linker settings for non-Apple platform when use static swift stdlib #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…libs - remove the platform specifics from computeLibraryArgs (we cannot assume that all libraries have a lib prefix and what there suffix is.) So we now use the FileType prefix and remove any suffix when using searchPathFlagsForLD, moving this into the LinkerSpec.LibrarySpecifier extension, this allows for proper searching of libraries, and linking of dynamic libraries (especially on Windows).
Update the linker settings on non-Apple platforms when use static Swift stdlib is set.
bkhouri
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh9320_rdar163948614_add_swift-static-stdlib_support
branch
from
e226a68 to
8d4b214
Compare
Contributor
Author
|
@swift-ci test |
rconnell9
reviewed
Nov 26, 2025
| args += [sdkPathArgument] | ||
|
|
||
| if !forTAPI { | ||
| if shouldStaticLinkStdlib { |
Contributor
There was a problem hiding this comment.
Curious why we are making changes here if the feature is not supported on macOS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the linker settings on non-Apple platforms when use static Swift. stdlib is set.
Fixes: swiftlang/swift-package-manager#9320
Issue: rdar://163948614
Depends on #890