🍒 integrate changes from cmark-gfm 0.29.0.gfm.12 and gfm.13 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Normalize nomenclature: marker row vs. delimiter row
The code for the table extension used the term 'marker row',
but the spec calls it 'delimiter row'.
This change normalizes the terminology so that it's consistent.
* Update autolink.c
```
../../../../ext/markly/autolink.c: In function ‘postprocess_text’:
../../../../ext/markly/autolink.c:364:31: warning: passing argument 1 of ‘validate_protocol’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
364 | if (validate_protocol("mailto:", data + start + offset + max_rewind, rewind, max_rewind)) {
| ^~~~~~~~~
../../../../ext/markly/commonmark.c: In function ‘S_render_node’:
../../../../ext/markly/autolink.c:299:36: note: expected ‘char *’ but argument is of type ‘const char *’
299 | static bool validate_protocol(char protocol[], uint8_t *data, size_t rewind, size_t max_rewind) {
| ~~~~~^~~~~~~~~~
```
* Update commonmark.c
```
../../../../ext/markly/commonmark.c:405:18: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
405 | emph_delim = "_";
| ^
```
* Fix GHSL-2023-119: prevent quadratic performance by not allowing very deeply nested footnote definitions.
* Fix GHSL-2023-117: store cell index on node so that it doesn't need to be recomputed during rendering.
* Fix GHSL-2023-118: limit number of autocompleted table cells to prevent DOS.
* Expose CMARK_NODE_FOOTNOTE_DEFINION literal value.
In addition, fix a bug where the length of the literal value was
calculated AFTER the actual literal string (null terminated) was
allocated.
* Update src/node.h
Co-authored-by: Phill MV <phillmv@github.com>
* Rename custom_int -> cell_index.
* Add newline
* Remove unnecessary scope.
* Create codeql.yml
* Changelog and version bump for 0.29.0.12
* Fix format specifier for printing a size_t
* Changelog and version bump for 0.29.0.13
* move cell index into node_cell_data
---------
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Phill MV <phillmv@github.com>
Co-authored-by: Bas Alberts <13686387+anticomputer@users.noreply.github.com>
Co-authored-by: Bas Alberts <anticomputer@github.com>
franklinsch
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #61
rdar://113206833