Prefer the pthread types from CDispatch #3107
Conversation
The types `pthread_mutex_t` and `pthread_cond_t` were defined via both `SwiftGlibc` and `CDistpatch` but a clang fix should merge these decls and consider `CDispatch` as the true origin. rdar://84677782
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@MaxDesiatov Do you remember why you added these lines? I'm wondering if you may have run into the same duplicated definition issue we're trying to fix in clang with swiftlang/llvm-project#3497. |
|
It could be, but these lines no longer have any effect when building for WASI. libc module on that platform is no longer called |
|
Sounds good then, thank you for the information Max! The Linux tests are failing in SwiftDocCTests, it looks unrelated. |
|
@swift-ci Please test Linux |
1 similar comment
|
@swift-ci Please test Linux |
|
The Linux tests are broken by the DocC tests that rely in networking and unusual temporary directory. (rdar://85055022) |
|
@swift-ci Please test Linux |
|
One more tweak will be needed but this one should be safe by itself. |
The types
pthread_mutex_tandpthread_cond_twere defined via bothSwiftGlibcandCDistpatchbut a clang fix should merge these decls and considerCDispatchas the true origin.Let's first see if we still need the explicit reference to
Glibcwhen referring to those types.rdar://84677782