build: support system installed BlocksRuntime #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @MadCoder @millenomi |
|
@swift-ci please test |
This uses the standard CMake mechanism for finding the blocks runtime. If one is not found, one will be provided for you.
|
@swift-ci please test |
|
What is the motivation here? I'm worried about random blocks runtimes, we've made fixes to the copy we have. |
Merged
|
The swift instructions tell you to install and build against the blocks runtime (via apt-get). This enables that. It also allows you to switch between the version in s-f-l or dispatch or if you have a copy checked out (like libclosure) or from compiler-rt. |
|
mmk |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: support system installed BlocksRuntime Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the standard CMake mechanism for finding the blocks runtime.
If one is not found, one will be provided for you.