build: always copy the modulemaps #412
Conversation
Change from a symlink to a copy. This is more portable and fixes the distribution aspect. When the installation occurs, the symbolic link is not followed and a symbolic link is installed. Rather if we copy, we can get the contents. The files are small so the cost is relatively low.
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
CI failed because build-script invocation is missing this argument for some reason: '--llvm-install-components=llvm-cov;llvm-profdata' /cc @shahmishal @gottesmm |
|
Ok. We should get this in ASAP to unbreak the package build. Let me look at this real quick. |
|
Dispatch isn't using a build-script preset... |
|
This preset will work: swiftlang/swift#20109. I asked @shahmishal to update the bots once it lands. |
|
preset=buildbot_linux_1604,notest |
|
@compnerd until @shahmishal changes the PR job to invoke the preset can't work |
|
Updated the PR job with |
|
@swift-ci test |
|
FYI - I merged this PR to unblock swift.org toolchains. |
build: always copy the modulemaps Signed-off-by: Kim Topley <ktopley@apple.com>
Change from a symlink to a copy. This is more portable and fixes the
distribution aspect. When the installation occurs, the symbolic link is
not followed and a symbolic link is installed. Rather if we copy, we
can get the contents. The files are small so the cost is relatively
low.