-
Notifications
You must be signed in to change notification settings - Fork 469
Handle multibyte paths on Windows #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @compnerd |
compnerd
reviewed
Jan 20, 2025
addd018
to
d8f101e
Compare
Update:
@compnerd please take a look |
d8f101e
to
7f6ffb1
Compare
compnerd
reviewed
Jan 24, 2025
7f6ffb1
to
97a4889
Compare
Reworked version
cc @compnerd |
compnerd
approved these changes
Feb 4, 2025
@swift-ci please test |
@swift-ci please test Windows platform |
97a4889
to
ae1524c
Compare
compnerd
approved these changes
Feb 5, 2025
@swift-ci please test |
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DispatchIO
is used in FoundationNetworking.URLSession for a file reading. The path is taken fromURL.withUnsafeFileSystemRepresentation
, which looks as expected behavior to me. It is multibyte string in fact, and on the Dispatch side we have to handle this accordingly.We noted this as crashes/hangs in our product, happening when we tried to POST files with non-ascii characters in the path. We are running with this patch without any issues for a few months already, so it is kind of tested. We're running on 5.10.1 release branch, but as long as
withUnsafeFileSystemRepresentation
is not changed, everything should be the same.