Skip to content

Re-enable ability to override icons in "Topics" section #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mportiz08
Copy link
Contributor

Bug/issue #, if applicable: 145880145

Summary

This re-enables the ability for the renderer to override the default page icons and display a custom one in the "Topics" section when available.

Specifically, the merge commit from #774 was reverted and one additional change was made to force these icons to display in grayscale for consistency purposes. Originally this functionality was disabled due to consistency issues with custom icon colors, but by enforcing a grayscale look and feel, we should be able to re-enable this.

Testing

Steps:

  1. Configure a custom icon for an article
  2. Curate that article in the "Topics" section somewhere else and verify that the custom icon renders in that page instead of the default article icon

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

mportiz08 added 2 commits May 1, 2025 13:39
This is a workaround for the inability to explicitly override the color
of the SVG fill when it is embedded as an <img>.

This workaround is needed to ensure that all icons (builtin or custom
overrides) are presented with a similar gray color for consistency.
@mportiz08 mportiz08 requested review from eango and marinaaisa May 1, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants