Re-enable ability to override icons in "Topics" section #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the inability to explicitly override the color of the SVG fill when it is embedded as an <img>. This workaround is needed to ensure that all icons (builtin or custom overrides) are presented with a similar gray color for consistency.
marinaaisa
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 145880145
Summary
This re-enables the ability for the renderer to override the default page icons and display a custom one in the "Topics" section when available.
Specifically, the merge commit from #774 was reverted and one additional change was made to force these icons to display in grayscale for consistency purposes. Originally this functionality was disabled due to consistency issues with custom icon colors, but by enforcing a grayscale look and feel, we should be able to re-enable this.
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded