encode relationshipsByLanguage and orphanRelationships in dump-unified-graph #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: None
Summary
When #28 landed, the code for dump-unified-graph was not updated to use the new relationship data. This PR updates the Encodable extension on UnifiedSymbolGraph to use the
relationshipsByLanguageandorphanRelationshipsproperties instead of the old unifiedrelationshipsproperty. This removes a deprecation warning when building SymbolKit.Dependencies
None
Testing
Rerun the testing instructions for #29. The Xcode 14 beta will generate multiple symbol graphs per-language, so passing the symbol-graph directory from a project's build folder to
--symbol-graph-dirwill work.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded