Add delete highlights #589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natikgadzhi
reviewed
Jun 4, 2023
| return Result(file: new, highlights: highlights) | ||
| let deleteHighlights = diff.removals.compactMap { removal -> Highlight? in | ||
| guard case .remove(let offset, _, _) = removal else { return nil } | ||
| // Use 1-based indexing for line numbers. |
There was a problem hiding this comment.
Nit: cleanup the comment (it's the same as above). Perhaps extract that little block into a func if it's reused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Close #515
Summary
Provide a description of what your PR addresses, explaining the expected user experience.
Also, provide an overview of your implementation.
Dependencies
Describe any dependencies this PR might have, such as an associated branch in another repository.
Testing
Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded