Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview issue on macOS and Linux #613

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Jun 7, 2023

Bug/issue #, if applicable:

Summary

A follow-up PR to fix the issue introduced by #604 - Unable to use PreviewAction on all platforms.

Dependencies

Describe any dependencies this PR might have, such as an associated branch in another repository.

Testing

Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.

Steps:

  1. Provide setup instructions.
  2. Explain in detail how the functionality can be tested.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 7, 2023

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the typo!

@Kyle-Ye Kyle-Ye force-pushed the bugfix/kyle/preview branch from 8d85e25 to f2c4117 Compare June 7, 2023 13:58
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 7, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye merged commit bbafd91 into swiftlang:main Jun 7, 2023
@Kyle-Ye Kyle-Ye deleted the bugfix/kyle/preview branch June 7, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants