Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.9] deprecate ExternalLocationReference in favor of DownloadReference #639

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[5.9] deprecate ExternalLocationReference in favor of DownloadReference #639

merged 2 commits into from
Jun 23, 2023
+55 −87

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #638

  • Explanation: This PR refactors DownloadReference to perform the same behavior as ExternalLocationReference, and changes @CallToAction to emit the former.
  • Scope: Affects users of @CallToAction.
  • Issue: rdar://111121386
  • Risk: Low. The two types were already tested to be Codable-compatible, so the only net change is that the references created by @CallToAction will use the download kind instead of externalLocation.
  • Testing: Automated tests have been updated to ensure that behavior stays the same.
  • Reviewer: @ethan-kusters

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@daniel-grumberg daniel-grumberg merged commit 83b9822 into swiftlang:release/5.9 Jun 23, 2023
@QuietMisdreavus QuietMisdreavus deleted the 5.9/unify-external-locations branch June 23, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuietMisdreavus @franklinsch @daniel-grumberg