Indexing: add a workaround for clearing the index #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this is the best approach for this, and I'm open to additional approaches - @d-ronnqvist @daniel-grumberg |
|
@swift-ci please test |
Kyle-Ye
requested changes
Jul 6, 2023
Kyle-Ye
reviewed
Jul 6, 2023
|
Thanks @Kyle-Ye I definitely like this approach much better, it is cleaner. |
Kyle-Ye
reviewed
Jul 6, 2023
|
@swift-ci please test |
Kyle-Ye
approved these changes
Jul 6, 2023
The unit tests will occasionally desire to clean up the generated index while retaining a reference to the NavigatorIndex instance. This is prevented on Windows as the LMDB environment will preserve an open handle which results in the index not being removed. Adding an internal API to support this use case as this is used for tests only AFAICT.
Co-authored-by: Kyle <kyle201817146@gmail.com>
Co-authored-by: Kyle <kyle201817146@gmail.com>
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests will occasionally desire to clean up the generated index while retaining a reference to the NavigatorIndex instance. This is prevented on Windows as the LMDB environment will preserve an open handle which results in the index not being removed.
Adding an internal API to support this use case as this is used for tests only AFAICT.