[Static Linux SDK] Build script improvements. #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on an aarch64 host, we need to download a different version of the Swift compiler in order to do the build. If we run the build on a macOS host, we also have to tell the update-checkout script to fetch all the required dependencies (even Linux-only ones). Also tell Foundation where swift-collections lives, to avoid it fetching another copy.
shahmishal
approved these changes
Sep 18, 2024
al45tair
force-pushed
the
aarch64-build-scripts
branch
9 times, most recently
from
fb94d05
to
7877836
Compare
Make sure we run the Docker builds in the directory containing the Dockerfile. Also, prefer lists of arguments rather than strings, especially when including filenames.
al45tair
force-pushed
the
aarch64-build-scripts
branch
from
7877836
to
29a51a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on an aarch64 host, we need to download a different version of the Swift compiler in order to do the build. If we run the build on a macOS host, we also have to tell the update-checkout script to fetch all the required dependencies (even Linux-only ones).
Also tell Foundation where swift-collections lives, to avoid it fetching another copy.