Android: add the stdlib RPATH when natively building on Android with Termux #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Termux This is the equivalent of the already-merged C++ Driver change in swiftlang/swift#69538.
|
@swift-ci test |
|
Ping, passed CI, ready for merge. |
|
Ping @artemcm, ready for merge. |
|
@swift-ci test |
|
@artemcm, this can be merged. |
|
Ping, @artemcm. |
|
@artemcm, anything holding this up? |
|
Pinging @artemcm again, ready for merge. |
|
Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of the already-merged C++ Driver change in swiftlang/swift#69538.
@artemcm, let me know what you think of this small change to align the two drivers and get one of my patches for the native Android toolchain upstreamed. This changes nothing other than when natively building Swift code on an Android device.