[BridgingHeader] Provide a deterministic unique pch file path #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artemcm let me know what you think about this. The dependency scanner is not yet returning the context hash for main module but that can be easily added. |
artemcm
approved these changes
Mar 20, 2024
| @@ -1779,7 +1781,7 @@ extension Driver { | |||
| /// The swift-driver doesn't have actions, so the logic here takes the jobs and tries | |||
| /// to mimic the actions that would be created by the C++ driver and | |||
| /// prints them in *hopefully* the same order. | |||
| private func printActions(_ jobs: [Job]) { | |||
| private mutating func printActions(_ jobs: [Job]) { | |||
There was a problem hiding this comment.
Using lazy var is mutating as I just learnt about it too.
cachemeifyoucan
force-pushed
the
eng/PR-pch-path-computation
branch
from
8b7a7b0 to
14a8d8e
Compare
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-pch-path-computation
branch
from
14a8d8e to
c7f8a22
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Teach swift driver to use a deterministic path for compiled PCH output. Also when dependency scanner is updated to return a module scanning or PCH hash from the scanning result, it will add that to the code path to have an unique PCH file path for the specific compilation.
cachemeifyoucan
force-pushed
the
eng/PR-pch-path-computation
branch
from
c7f8a22 to
bb3eed3
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach swift driver to use a deterministic path for compiled PCH output. Also when dependency scanner is updated to return a module scanning or PCH hash from the scanning result, it will add that to the code path to have an unique PCH file path for the specific compilation.