[CAS] Fix task continuation misuse when CAS error happens #1591
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
changed the title
Do not resume with returning after resume with throwing when there is an error returned from CAS service.
cachemeifyoucan
force-pushed
the
eng/PR-fix-continuation-misuse
branch
from
605e832 to
9aa8de3
Compare
|
@swift-ci please test |
benlangmuir
approved these changes
May 1, 2024
No easily. Need a libSwiftScan C API implementation that returns error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not resume with returning after resume with throwing when there is an error returned from CAS service.