Skip to content

Response files should be named using the hash of the command line arguments only #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

Response files should be named using the hash of the command line arguments only #1636

merged 1 commit into from
Jun 21, 2024

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jun 21, 2024

  • Including the full hash of the job can lead to unnecessary duplication of the file, inhibiting job deduplication
  • Use a stable hash to ensure the response file name does not change from one process execution to the next

@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2024

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor

LGTM. Can you add a test case for this?

@owenv owenv force-pushed the pr/ovoorhees/deterministic-response-file-hashing branch from 90b1568 to 2581af8 Compare June 21, 2024 16:44
@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2024

Added a basic test

@swift-ci please test

@owenv owenv force-pushed the pr/ovoorhees/deterministic-response-file-hashing branch from 2581af8 to ed363ec Compare June 21, 2024 20:49
@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2024

@swift-ci please test

@owenv
Copy link
Contributor Author

owenv commented Jun 21, 2024

@swift-ci please test Windows platform

@owenv owenv mentioned this pull request Jun 21, 2024
Merged
@owenv owenv merged commit 3519916 into swiftlang:main Jun 21, 2024
3 checks passed
artemcm
artemcm reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm left review comments

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owenv @cachemeifyoucan @nkcsgexi @artemcm