Pass -lld-allow-duplicate-weak for coverage on Windows
#1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jul 9, 2024
Profiling currently relies on the ability to emit duplicate weak symbols across translation units and having the linker coalesce them. Unfortunately `link.exe` does not support this, so require `lld-link` and pass `-lld-allow-duplicate-weak` when `-profile-generate` is passed. We ought to be able to remove this once coverage is changed to not rely on duplicate weak symbols, rdar://131295678 is tracking that. rdar://129337999
hamishknight
force-pushed
the
windows-coverage
branch
from
4baf2e4 to
e206bfd
Compare
|
@swift-ci please test |
compnerd
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling currently relies on the ability to emit duplicate weak symbols across translation units and having the linker coalesce them. Unfortunately
link.exedoes not support this, so requirelld-linkand pass-lld-allow-duplicate-weakwhen-profile-generateis passed. We ought to be able to remove this once coverage is changed to not rely on duplicate weak symbols, rdar://131295678 is tracking that.rdar://129337999