Skip to content

[Test Only] Make CachingBuildTests.testDependencyScanning be adaptable to scanner diagnostic revisions #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 10, 2024

Instead of throwing a failure, a scan may return a hollow result carrying diagnostic error payload

@artemcm artemcm requested a review from cachemeifyoucan July 10, 2024 16:57
@artemcm
Copy link
Contributor Author

artemcm commented Jul 10, 2024

@swift-ci test

…ble to scanner diagnostic revisions

Instead of throwing a failure, a scan may return a hollow result carrying diagnostic error payload
@artemcm artemcm force-pushed the TestFixForCachingDiags branch from 37f20eb to 6cc835e Compare July 10, 2024 17:32
@artemcm
Copy link
Contributor Author

artemcm commented Jul 10, 2024

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jul 10, 2024

@swift-ci test Windows platform

@artemcm artemcm merged commit f4709ef into swiftlang:main Jul 11, 2024
3 checks passed
@artemcm artemcm deleted the TestFixForCachingDiags branch July 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants