Revert "SwiftDriver: initial work to properly handle android cross-compilation" #1662
+8
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
finagolfin
reviewed
Jul 13, 2024
| if targetInfo.sdkPath != nil { | ||
| for libpath in targetInfo.runtimeLibraryImportPaths { | ||
| commandLine.appendFlag(.L) | ||
| commandLine.appendPath(VirtualPath.lookup(libpath.path)) |
There was a problem hiding this comment.
This is adding new runtime library paths to all platforms when -sdk is specified, which could be causing build errors.
|
@swift-ci please test Linux |
hborla
approved these changes
Jul 13, 2024
|
Merging to unblock PR testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1560
Tentative revert to see if it resolves PR testing on the main repo.