Pass -enable-cmo-everything to frontend jobs
#1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS |
FranzBusch
reviewed
Jul 13, 2024
| @@ -370,6 +371,7 @@ extension Driver { | |||
|
|
|||
| try commandLine.appendLast(.trackSystemDependencies, from: &parsedOptions) | |||
| try commandLine.appendLast(.CrossModuleOptimization, from: &parsedOptions) | |||
| try commandLine.appendLast(.EnableCMOEverything, from: &parsedOptions) | |||
There was a problem hiding this comment.
Do we have to handle if any combination of -cross-module-optimization, -enable-default-cmo and -enable-cmo-everything is passed that the more aggressive one wins or does swiftc already handle that?
There was a problem hiding this comment.
The frontend has logic for choosing the single level of optimization based on the presence of conflicting flags. It works a bit differently than I would expect; I think a more standard way to handle that would be to use whichever of the three flags comes last on the command line, but there is at least a strategy for resolving conflicts.
owenv
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the
-enable-cmo-everythingflag down to frontend jobs and suppress-enable-default-cmowhen we do, just like with-cross-module-optimization.Additional drive-by fixes:
Options.swiftup-to-date.-warn-soft-deprecatedflag through to frontend jobs.Resolves rdar://128401284.