Skip to content

Add new parameters to OPTION macro #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

bnbarham
Copy link
Contributor

As in most LLVM updates, OPTION has been modified. Update makeOptions.cpp to take this into account.

As in most LLVM updates, `OPTION` has been modified. Update
`makeOptions.cpp` to take this into account.
@bnbarham bnbarham requested review from compnerd and artemcm August 21, 2024 02:29
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@compnerd
Copy link
Member

@swift-ci please test Linux platform

@compnerd
Copy link
Member

The Windows failure is acceptable - it is failing at testing Swift:

Failed Tests (7):
  Swift(windows-x86_64) :: Frontend/output_determinism_check.swift
  Swift(windows-x86_64) :: IRGen/async/class_resilience.swift
  Swift(windows-x86_64) :: IRGen/async/protocol_resilience.swift
  Swift(windows-x86_64) :: Interop/Cxx/class/method/methods-this-and-indirect-return-irgen-msvc.swift
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-out-of-line-irgen.swift
  Swift-Unit :: Basic/./SwiftBasicTests.exe/FileSystem/MoveFileIfDifferentEmpty
  Swift-Unit :: Basic/./SwiftBasicTests.exe/FileSystem/MoveFileIfDifferentNonEmpty

@bnbarham
Copy link
Contributor Author

I'm just going to merge, the linux failure is infrastructure related and I don't plan on making any other changes to swift-driver in rebranch. I'll just keep an eye on the jobs.

@bnbarham bnbarham merged commit 2cac18a into swiftlang:rebranch Aug 21, 2024
1 of 3 checks passed
@bnbarham bnbarham deleted the fix-options branch August 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants