[Tests] Remove all hard-coded macOS targets in explicit module tests #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Sep 5, 2024
|
Holding on. Bots are actually not green for Linux as the test failures are hidden. |
|
@swift-ci please test |
compnerd
approved these changes
Sep 5, 2024
| @@ -1,4 +1,4 @@ | |||
| #if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ < 110000 | |||
| #if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) && __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ < 1050 | |||
There was a problem hiding this comment.
Suggested change
| #if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) && __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ < 1050 | |
| #if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__-0 < 1050 |
There was a problem hiding this comment.
I am actually intended to have this to be false on Linux/Windows.
cachemeifyoucan
force-pushed
the
eng/PR-module-plan-no-hard-coded-targets
branch
2 times, most recently
from
17f0319 to
c3b367e
Compare
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-module-plan-no-hard-coded-targets
branch
from
c3b367e to
bb03664
Compare
Remove all the hard coded macOS tests for module scanning and planning. Feed stdlib and shims into the tests instead to support all targets for those tests.
cachemeifyoucan
force-pushed
the
eng/PR-module-plan-no-hard-coded-targets
branch
from
bb03664 to
8bc8927
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
artemcm
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the hard coded macOS tests for module scanning and planning. Feed stdlib and shims into the tests instead to support all targets for those tests.