Only pass --rsp-quoting=windows to clang
#1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were unconditionally passing `--rsp-quoting` to the linker on Windows. As far as I can tell, there are three different linkers we invoke on Windows: - `clang.exe`: This is what this fix is intended to cover - `lld-link.exe`: Defaults to Windows quoting style in response files and `--rsp-quoting=windows` is a no-op. - `link.exe`: Does not accept `--rsp-quoting=windows` Move `--rsp-quoting=windows` to the point where we decide to use `clang.exe` as the linker on Windows and only pass it to `clang.exe`.
|
@swift-ci Please test |
hjyamauchi
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unconditionally passing
--rsp-quotingto the linker on Windows. As far as I can tell, there are three different linkers we invoke on Windows:clang.exe: This is what this fix is intended to coverlld-link.exe: Defaults to Windows quoting style in response files and--rsp-quoting=windowsis a no-op.link.exe: Does not accept--rsp-quoting=windowsMove
--rsp-quoting=windowsto the point where we decide to useclang.exeas the linker on Windows and only pass it toclang.exe.