swift-driver: correct the legacy driver path construction #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `URL` to compute the new executable name. This is important to ensure that we correctly strip the executable suffix and re-apply it in the proper location if applicable. Without this change, on Windows, the fallback path would generate `swiftc.exe-legacy-driver` rather than `swiftc-legacy-driver.exe` for the basename of the C++ driver.
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
artemcm
approved these changes
Dec 2, 2024
|
@artemcm @compnerd is it possible this is related to https://ci.swift.org/job/swift-PR-Linux/18443/console |
|
I've merged the revert because it looks like this broke PR testing. |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Dec 4, 2024
swiftlang/swift-driver#1741 fixed a bug in the swift-driver which exposed a bug in this test. The use of `%FileCheck` is a problem as that sanitises the output substituting `BUILD_DIR` for the build directory that is now properly computed. Because `PATH` is being configured to an invalid path the actual driver is not found and the test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
URLto compute the new executable name. This is important to ensure that we correctly strip the executable suffix and re-apply it in the proper location if applicable. Without this change, on Windows, the fallback path would generateswiftc.exe-legacy-driverrather thanswiftc-legacy-driver.exefor the basename of the C++ driver.