SwiftDriver performance fixes for swift caching #1825
+112
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
benlangmuir,
artemcm,
fredriss and
tshortli
|
@swift-ci please test |
Borrow the implementation from stdlib test for a faster way to bridging swift `[String]` to `const char **`. Instead of strdup every string which can be costly if the argument list is very long, use one single big allocation to hold all the strings.
When using incremental build, the FirstWaveComputer has already batched all the compile jobs. `planStandardCompile()` can just reuse the batch job information from incremental state to construct the jobs.
cachemeifyoucan
force-pushed
the
eng/PR-swift-driver-perf-for-caching
branch
from
2c8b812 to
ccae5a1
Compare
|
@swift-ci please test |
During batch mode, the initially computed compilation tasks will be batched later. There is no need to compute cache keys for those Jobs since they will not be executed.
cachemeifyoucan
force-pushed
the
eng/PR-swift-driver-perf-for-caching
branch
from
ccae5a1 to
5ea08fe
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the performance of swift-driver when doing a batch planning for a very large module including thousands of files, the cache key computation is the bottle neck for performance. This PR includes fixes to eliminate some of the inefficiencies in the swift-driver that can cause unnecessary cache key computations. This PR includes:
-enable-batch-mode -incremental[String]and Cconst char **more efficient for swift scan interfaces.rdar://145298257