Add -sil-output-dir and -ir-output-dir driver options #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#84392 is the PR for the swift-frontend flags |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
DougGregor
reviewed
Oct 10, 2025
| flag: "-serialize-diagnostics-path") | ||
|
|
||
| // Add SIL and IR outputs when explicitly requested via directory options, file maps, or -save-temps | ||
| let saveTempsWithoutFileMap = parsedOptions.hasArgument(.saveTemps) && outputFileMap == nil |
There was a problem hiding this comment.
SwiftDriver is meant to provide some forward/backward compatibility with different swift-frontend versions. In this case where -save-temps has been provided, can this check whether the frontend supports the -sil-output-dir option before it it concludes that it should pass the option down? Otherwise, new driver with old swift-frontend will fail for existing users of -save-temps.
This enables generating SIL and LLVM IR files during normal compilation using the frontend -sil-output-path and -ir-output-path flags. Supports both single-file and WMO modes with file map integration. rdar://160297898
This extends -save-temps to emit SIL and IR alongside existing temporary files. In the case where an output file map is used with -save-temps, e.g. incremental compilation, only emit the SIL and IR if it has been requested as an output in the filemap. rdar://160297896
rjmansfield
force-pushed
the
sil-ir-outputdirs
branch
from
e062312 to
8bf76e3
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Oct 14, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables generating SIL and LLVM IR files during normal compilation using the frontend -sil-output-path and -ir-output-path flags.
Supports both single-file and WMO modes with ile map integration.
rdar://160297898